clean up PyPI metadata #1480
Merged
clean up PyPI metadata #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaskruchten
commented
Mar 27, 2019
| long_description=readme(), | ||
| long_description_content_type="text/markdown", |
There was a problem hiding this comment.
This enables us to use Markdown
nicolaskruchten
commented
Mar 27, 2019
| classifiers=[ | ||
| 'Development Status :: 4 - Beta', | ||
| 'Development Status :: 5 - Production/Stable', |
There was a problem hiding this comment.
I think we're there!
nicolaskruchten
commented
Mar 27, 2019
| @@ -394,17 +394,20 @@ def run(self): | |||
| maintainer='Chris P', | |||
| maintainer_email='[email protected]', | |||
| url='https://plot.ly/python/', | |||
| description="Python plotting library for collaborative, " | |||
| "interactive, publication-quality graphs.", | |||
| project_urls={"Github": "https://github.com/plotly/plotly.py"}, | |||
There was a problem hiding this comment.
This just gets a bit more metadata on the PyPI page to show up automatically
nicolaskruchten
commented
Mar 27, 2019
| @@ -30,7 +30,7 @@ def plotly_js_version(): | |||
|
|
|||
|
|
|||
| def readme(): | |||
| with open('README.rst') as f: | |||
| with open('README.md') as f: | |||
There was a problem hiding this comment.
This is what's on Github by default and is much more up to date than the one on PyPI
nicolaskruchten
commented
Mar 27, 2019
| @@ -1,5 +1,5 @@ | |||
| [metadata] | |||
| description-file = README.rst | |||
| description-file = README.md | |||
There was a problem hiding this comment.
unsure about the impact of this...
nicolaskruchten
commented
Mar 27, 2019
setup.py
Outdated
| @@ -394,17 +394,20 @@ def run(self): | |||
| maintainer='Chris P', | |||
There was a problem hiding this comment.
We should consider making this @jonmmease
jonmmease
approved these changes
Apr 10, 2019
|
Might be worth a push to test.pypi.org first to check that the formatting etc looks good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.